PR Reviews
LGTM?
PR Reviews are INVALUABLE. It is one of the least talked about way to become a better engineer. My growth for the past 6 months has been insane to say the least and I would credit a lot of them to how I approach and treat PR reviews. Here are some things I keep in mind when doing reviews for other people. 1. Mindset. Realising that a review isnât just a step in approving a piece of work, but rather another piece of work weighted equally as the work youâre reviewing. 2. What do you like from their work? â¨Take notes. Plenty of notes. Youâll find points you can take home and implement in your own craft that you wont find easily from tutorials or likes of it.â¨And do leave compliments! Making people feel happy goes a long way. 3. How do you think this can be improved?⨠The point is not to find points of disagreement, but constructive feedback that would be valuable for both of you. Does it (need to) scale? Risks to mitigate? 4. What other approaches you can think of to solve the same problem? 5. Ask questions!⨠It is okay to not have full context, in fact, it might be better that way. Not everyone arriving at your code will understand what it does at first glance, even the action of asking questionsâ¨Furthermore, if you are in a healthy workspace, it is very likely that they will be more than happy to help you. Think twice before you say LGTM on your next review đ
â back